[Numpy-discussion] what to clean up, what to leave as is

Charles R Harris charlesr.harris at gmail.com
Fri Jan 24 12:28:29 EST 2020


On Fri, Jan 24, 2020 at 9:46 AM Ralf Gommers <ralf.gommers at gmail.com> wrote:

> Hi all,
>
> It's great to see that people are jumping at the chance to clean up Python
> 2 support. I would however caution about overdoing it on other cleanups. As
> a reminder, we normally do not want pure style PRs (e.g. PEP8 cleanups),
> because they make the code history (git blame, commits on particular files,
> etc.) harder to work with, have review overhead, and may introduce new bugs
> for little gain.
>
> Imho that same rationale applies to things like converting strings to
> f-strings. There's of course some gray area, for example removing "from ...
> import *" can guard against accidentally exposing new API, so can be
> considered a valuable cleanup.
>
> As a separate/additional point: numpy.distutils and numpy.f2py are largely
> untested, PRs are hard to test locally because of platform-specific code,
> and changes often introduce regressions. So even for some cleanups that are
> okay for other files, please do not do them on those modules.
>
>
I do like f-strings, they can make the code simpler and more readable.

Chuck
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/numpy-discussion/attachments/20200124/6b8d177e/attachment.html>


More information about the NumPy-Discussion mailing list