<div dir="ltr">My view is that we will not add more non-uniform distribution (i.e. "named" statistical probability distributions like Polya-Gamma) methods to `Generator`. I think that we might add a couple more methods to handle some more fundamental issues (like sampling from the unit interval with control over whether each boundary is open or closed, maybe one more variation on shuffling) that helps write randomized algorithms. Now that we have the C and Cython APIs which allow one to implement non-uniform distributions in other packages, we strongly encourage that.<div><br></div><div>As I commented on the linked PR, `scipy.stats` would be a reasonable place for a Polya-Gamma sampling function, even if it's not feasible to implement an `rv_continuous` class for it. You have convinced me that the nature of the Polya-Gamma distribution warrants this. The only issue is that scipy still depends on a pre-`Generator` version of numpy. So I recommend implementing this function in your own package with an eye towards contributing it to scipy later.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Dec 27, 2020 at 6:05 AM Zolisa Bleki <<a href="mailto:BLKZOL001@myuct.ac.za" target="_blank">BLKZOL001@myuct.ac.za</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Hi All,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
I would like to know if Numpy accepts addition of new distributions since the implementation of the Generator interface. If so, what is the criteria for a particular distribution to be accepted? The reason why i'm asking is because I would like to propose adding
the Polya-gamma distribution to numpy, for the following reasons:</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
1) Polya-gamma random variables are commonly used as auxiliary variables during data augmentation in Bayesian sampling algorithms, which have wide-spread usage in Statistics and recently, Machine learning.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
2) Since this distribution is mostly useful for random sampling, it since appropriate to have it in numpy and not projects like scipy [1].</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
3) The only python/C++ implementation of the sampler available is licensed under GPLv3 which I believe limits copying into packages that choose to use a different license [2].<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
4) Numpy's random API makes adding the distribution painless.<br>
<div><br>
</div>
<div>I have done preliminary work on this by implementing the distribution sampler as decribed in [3]; see:
<a href="https://github.com/numpy/numpy/compare/master...zoj613:polyagamma" id="gmail-m_-6444358034245858012gmail-m_89276148322918208LPlnk" target="_blank">
https://github.com/numpy/numpy/compare/master...zoj613:polyagamma</a> .</div>
<div>There is a more efficient sampling algorithm described in a later paper [4], but I chose not to start with that one unless I know it is worth investing time in.<br>
</div>
<div></div>
<br>
I would appreciate your thoughts on this proposal.</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Regards,</div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
Zolisa<br>
<div><br>
</div>
<div><br>
</div>
<div>Refs:</div>
<div>[1] <a href="https://github.com/scipy/scipy/issues/11009" id="gmail-m_-6444358034245858012gmail-m_89276148322918208LPlnk160222" target="_blank">https://github.com/scipy/scipy/issues/11009</a></div>
<div>[2] <a href="https://github.com/slinderman/pypolyagamma" id="gmail-m_-6444358034245858012gmail-m_89276148322918208LPlnk" target="_blank">https://github.com/slinderman/pypolyagamma</a><br>
</div>
<div></div>
[3] <a href="https://arxiv.org/pdf/1205.0310v1.pdf" id="gmail-m_-6444358034245858012gmail-m_89276148322918208LPlnk" target="_blank">https://arxiv.org/pdf/1205.0310v1.pdf</a><br>
<div></div>
[4] <a href="https://arxiv.org/pdf/1405.0506.pdf" id="gmail-m_-6444358034245858012gmail-m_89276148322918208LPlnk" target="_blank">https://arxiv.org/pdf/1405.0506.pdf</a><br>
<div></div>
<br>
<br>
<br>
</div>
Disclaimer - University of Cape Town This email is subject to UCT policies and email disclaimer published on our website at <a href="http://www.uct.ac.za/main/email-disclaimer" target="_blank">http://www.uct.ac.za/main/email-disclaimer</a> or obtainable from +27 21 650 9111. If this email is not related to the business of UCT, it
is sent by the sender in an individual capacity. Please report security incidents or abuse via <a href="https://csirt.uct.ac.za/page/report-an-incident.php" target="_blank">https://csirt.uct.ac.za/page/report-an-incident.php</a>.
</div>
_______________________________________________<br>
NumPy-Discussion mailing list<br>
<a href="mailto:NumPy-Discussion@python.org" target="_blank">NumPy-Discussion@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/numpy-discussion" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/numpy-discussion</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr">Robert Kern</div>