[Numpy-svn] [numpy/numpy] 2e0f8a: BUG, MAINT: Use keyword args internally in fromnum...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/numpy/numpy
  Commit: 2e0f8ab73f217319d9037bb801c96e9505cd3461
      https://github.com/numpy/numpy/commit/2e0f8ab73f217319d9037bb801c96e9505cd3461
  Author: gfyoung <gfyoung at mit.edu>
  Date:   2016-03-20 (Sun, 20 Mar 2016)

  Changed paths:
    M doc/release/1.12.0-notes.rst
    M numpy/core/fromnumeric.py

  Log Message:
  -----------
  BUG, MAINT: Use keyword args internally in fromnumeric.py

Internal method calls to array methods should be written
to reflect the actual signature of the argument. Thus,
keyword arguments for example should be written explicitly
as keyword arguments.

This inconsistency has caused libraries like pandas to
adopt somewhat awkward function signatures for functions
with name equivalents in numpy in which certain arguments had
to be externalized for compatibility purposes but would preferably
have been hidden in a kwargs argument since they weren't actually
used in the implementation. Such externalization would only cause
more confusion for the user.


  Commit: fdb05497a1501dc84c7942d85155b4cf4b22df95
      https://github.com/numpy/numpy/commit/fdb05497a1501dc84c7942d85155b4cf4b22df95
  Author: gfyoung <gfyoung17 at gmail.com>
  Date:   2016-03-21 (Mon, 21 Mar 2016)

  Changed paths:
    M numpy/core/fromnumeric.py

  Log Message:
  -----------
  BUG: Improve compatibility to account for slightly different signatures

In downstream libraries like pandas, they implement methods like 'round'
or 'searchsorted' but with slightly different arguments. However, that
causes a call like `np.round` to crash because numpy assumes that the
object's implementation of the method has a signature that  matches that
of numpy's.


  Commit: 11c8b4d48793e4b1227b2c5ae5c32d8178f285fc
      https://github.com/numpy/numpy/commit/11c8b4d48793e4b1227b2c5ae5c32d8178f285fc
  Author: Nathaniel J. Smith <njs at pobox.com>
  Date:   2016-03-22 (Tue, 22 Mar 2016)

  Changed paths:
    M doc/release/1.12.0-notes.rst
    M numpy/core/fromnumeric.py

  Log Message:
  -----------
  Merge pull request #7325 from gfyoung/wrapit_keyword

BUG, MAINT: Improve fromnumeric.py interface for downstream compatibility


Compare: https://github.com/numpy/numpy/compare/c70e88b17b6c...11c8b4d48793