[Patches] Please review before applying

[Guido van Rossum]

> > Wanted: reviews for this patch!  It seems usable but (as the author
> > admits) needs another careful eye before I can apply it.
> 
> I begun skimming over it and stumbled here:
> 
> --- 236,242 ----
>           elif requestline[-1:] == '\n':
>               requestline = requestline[:-1]
>           self.requestline = requestline
> !         words = requestline.split()
>           if len(words) == 3:
>               [command, path, version] = words
>               if version[:5] != 'HTTP/':
> ***************
> 
> Shouldn't we be consequent and use the new startswith methods
> as well, instead of if version[:5] != 'HTTP/' ?
> I think it would be better to do this all in one big shot.

No, I think it's fine to do it in one fell swoop.  You can either make
many of this kind of changes to one module or make one type of change
to many modules; if you try both, you'll touch too much and start
making mistakes.

--Guido van Rossum (home page: http://www.python.org/~guido/)