[Patches] urllib: POST with arbitrary mime type
Guido van Rossum
Mon, 24 Apr 2000 10:40:36 -0400
One suggestion -- rather than testing for type(data)==type(''),
wouldn't it be better to test for isinstance(data, RequestBody)?
Also, it seems that your Form class is broken. It passes a dict as
the body argument the the base class constructor, but it is later used
as a string.
I suggest that you test this one more extensively. Perhaps add some
testcases to test_urllib.py?
--Guido van Rossum (home page: http://www.python.org/~guido/)