[Patches] why not just apply Garbage Collection patch?

Charles G Waldman cgw@fnal.gov
Mon, 24 Apr 2000 14:38:20 -0500 (CDT)


Neil's GC is an excellent piece of work, and I hope it makes it into
1.6.  I spent a lot of time this Easter weekend reading the code and
playing around with it.

I'll do what I can to test it on large volumes of production code  (I
have plenty of machines at my disposal...)

Unfortunately, with my recent changes to tupleobject.c and Christian's
recent changes to the Trashcan, the gc patch no longer applies
cleanly, and after hand-patching, it doesn't seem to work (Python
hangs forever on startup, after printing a lone

  gc: collectable <Object 0x8189fb4>

message.

When I get some time, I'll try to find out why this is happening.

In the meanwhile, I propose that Neil's patch be applied to the main
CVS sources.  Since you have to enable it on the configure line with
"--with-cycle-gc" it seems harmless enough to just check the patches
in.  Then we don't have the problem of the GC stuff getting
out-of-sync with all the other changes that are happening.
Furthermore, the earlier it gets into the alpha process, the more
people will be encouraged to play around and test it out.  If it turns
out to be a disaster (I'm not expecting this!) we can just back it all
out, right?  Everything is already protected with "#ifdef
WITH_CYCLE_GC" anyhow, right?

Just my $0.002,

     	-C