[Patches] [Patch #101151] expose public get_fqdn function in smtplib.py

[Thomas Wouters]

On Tue, Aug 15, 2000 at 02:58:35PM -0400, Fred L. Drake, Jr. wrote:

> noreply@sourceforge.net writes:
>  > Patch #101151 has been updated. 
> ...
>  > Date: 2000-Aug-15 11:48
>  > By: twouters
>  > 
>  > Comment:
>  > I'm accepting this patch, since it's the right thing to do for
>  > now. If and when socketmodule is split into a C module and a Python
>  > wrapper, we can move the make_fqdn function there, and also remove
>  > the duplicate implementations from the other modules. I still think
>  > that's a good idea, but I can't deal with it at the moment (and I'm
>  > scared of doing it, too, because I donno what it would break :)
>  > 
>  > Accepted modulo the name change (get_fqdn -> make_fqdn) and I'll be
>  > checking it in, in a minute.
> 
>   Is there some reason we don't go ahead and change socket to _socket?
> As Barry rightly pointed out, that's already how it is for some
> (popular) platforms.

Well, I didn't do it myself (or upload it as a patch, rather) for a very
simple reason: I don't know how to do it without breaking stuff :) where
would socket.py go, that it would be available to all systems that currently
have socketmodule.so (or builtin socketmodule) without interfering with
systems that alrady have a socket.py in their own directory. Too much work
for me to figure out -> I didn't do it, and won't, until someone tells me to
:-)

-- 
Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!