[Patches] [Patch #101151] expose public get_fqdn function in smtplib.py

[noreply@sourceforge.net]

Patch #101151 has been updated. 

Project: 
Category: library
Status: Closed
Summary: expose public get_fqdn function in smtplib.py

Follow-Ups:

Date: 2000-Aug-10 16:32
By: nowonder

Comment:
expose get_fqdn function rather than calling internal _get_fqdn_hostname function. Only call from helo() and ehlo() if needed. refer from documentation's mentioning of algorithm for fqdn to implementation of get_fqdn.

should there be docs for quotedata() and get_fqdn() in libsmtplib.tex?
-------------------------------------------------------

Date: 2000-Aug-11 00:58
By: twouters

Comment:
Looks okay, though perhaps the function should be named 'make_fqdn()' instead of 'get_fqdn' -- you're passing it a name to operate on, after all. That's just a personal preference.

I'll let it float for a few days to let someone else knowledgable in the area of SMTP give their opinion on the whole FQDN issue, but as far as I'm concerned, this patch is accepted. Am I the moral equivalent of Guido here ? I have no clue :-)


-------------------------------------------------------

Date: 2000-Aug-11 01:33
By: nowonder

Comment:
as I write in my mail to python-dev, I have found three other occurences of the algorithm. Maybe this should go in some more general place. Where?

BTW: I like make_fqdn() better.
-------------------------------------------------------

Date: 2000-Aug-15 10:40
By: tim_one

Comment:
We have to take some action on this for 2.0 -- Accept, Postpone or Reject.  I don't know anything about SMTP.  If you're not sure you've gotten enough feedback here, bring it up on Python-Dev again.  Repeatedly and obnoxiously <wink>.
-------------------------------------------------------

Date: 2000-Aug-15 11:48
By: twouters

Comment:
I'm accepting this patch, since it's the right thing to do for now. If and when socketmodule is split into a C module and a Python wrapper, we can move the make_fqdn function there, and also remove the duplicate implementations from the other modules. I still think that's a good idea, but I can't deal with it at the moment (and I'm scared of doing it, too, because I donno what it would break :)

Accepted modulo the name change (get_fqdn -> make_fqdn) and I'll be checking it in, in a minute.

-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101151&group_id=5470