[Patches] [Patch #101170] Prevent old extensions from crashing

[noreply@sourceforge.net]

Patch #101170 has been updated. 

Project: 
Category: Windows
Status: Postponed
Summary: Prevent old extensions from crashing

Follow-Ups:

Date: 2000-Aug-12 01:55
By: chega

Comment:
This patch will prevent old (1.5/1.6) extensions from crashing under Python 2.0

(Also changed pathbuf[260] to pathbuf[MAX_PATH])
-------------------------------------------------------

Date: 2000-Aug-15 15:26
By: tim_one

Comment:
Assigned to MarkH.  Please review or pass on to someone else.
-------------------------------------------------------

Date: 2000-Aug-15 16:26
By: mhammond

Comment:
I'm not sure this is worth adding.  Note that we already have code to prevent a crash in place - however, rather than raising an exception it simply calls Py_FatalError.

This patch is potentially better, except that:
* It will require regressing the patch made to modsupport.c (Rev 2.50) to prevent the same problem; that code will prevent this code kicking in!

* It hard-codes the Python DLL names.  This makes long term maintenance a PITA, and yet another file that needs to be updated when a version bumps. Are there other alternatives?

* Once the module has been loaded, it may be too late to save the process anyway.  I realize that the module init hasnt been called yet, but the module has been loaded, and may be doing things in its DllMain() that will destabilize the process.

The big killer is simply that this code will never be triggered, as the check in modsupport.c will kick in first.

Setting to postponed until we can get a better handle on this.  A big advantage is that this style of change is not dependent on _old_ versions having the patch, only one actually running.  Hence we can revive this patch at any time, and have it start working immediately.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101170&group_id=5470