[Patches] [Patch #101214] Improve exception message for PyErr_BadInternalCall()

noreply@sourceforge.net noreply@sourceforge.net
Fri, 18 Aug 2000 07:42:54 -0700


Patch #101214 has been updated. 

Project: 
Category: core (C code)
Status: Open
Summary: Improve exception message for PyErr_BadInternalCall()

Follow-Ups:

Date: 2000-Aug-17 23:25
By: fdrake

Comment:
This patch uses a macro wrapper to provide the filename and line number of the call to PyErr_BadInternalCall().  This should be reasonable since the __FILE__ and __LINE__ macros are ANSI C (I think).  There are 77 call sites for PyErr_BadInternalCall(), and this would make it a lot easier to get an initial foothold on errors generated through this function.
-------------------------------------------------------

Date: 2000-Aug-18 07:15
By: marangoz

Comment:
OTOH, bad internal calls shouldn't happen, but I like this. You want to
make my life easier as a developer, not as a user. +0, modulo the fact
that you removed the original function from the API. External modules
may fail. Let's keep the original function and its signature in the code.
(this requires some preprocessor trickery).
-------------------------------------------------------

Date: 2000-Aug-18 10:42
By: fdrake

Comment:
Add PyErr_BadInternalCall() entry point back for legacy compiled code, but continue to mask it for new code.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101214&group_id=5470