[Patches] [Patch #100895] safe version of PyErr_Format

noreply@sourceforge.net noreply@sourceforge.net
Mon, 21 Aug 2000 18:42:15 -0700


Patch #100895 has been updated. 

Project: 
Category: core (C code)
Status: Open
Summary: safe version of PyErr_Format

Follow-Ups:

Date: 2000-Jul-17 17:56
By: effbot

Comment:
minor tweaks (mostly comments), based on input from moshe.
-------------------------------------------------------

Date: 2000-Jul-18 02:23
By: moshez

Comment:
I'm +1 on that! It will plug one more security hole in Python, and seems a "good enough" replacement for an unsure snprintf()
-------------------------------------------------------

Date: 2000-Aug-08 13:19
By: effbot

Comment:
regenerated, since moshez reported that it didn't apply cleanly to the current CVS tree.

reassigned, since it's been sitting here for ages.
-------------------------------------------------------

Date: 2000-Aug-11 00:04
By: tim_one

Comment:
Rejected and back to /F.

Major:  no docs!  Format strings processed by this have different semantics than anyone could guess (e.g., flags are ignored, width is ignored, some format codes are copied verbatim).  Reverse-engineering the code each time there's a question is just too painful.  You're basically inventing a new sublanguage here, so document what the heck it is & means.

Mechanical:
There's a "step 1" but no "step 2" <wink>.
We shouldn't be #ifdef'ing on prototypes anymore.
Guido did not yield to the push for 4-space indents in C code, so this should use hard tabs.

-------------------------------------------------------

Date: 2000-Aug-15 20:05
By: tim_one

Comment:
Changed status from Rejeced to Open so we only have to look in one place for the status of putative 2.0 patches.
But the patch is still *effectively* rejected pending response to the objections.
-------------------------------------------------------

Date: 2000-Aug-21 21:42
By: tim_one

Comment:
Just reminding you this is still on your plate.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=100895&group_id=5470