[Patches] [Patch #101211] list comprehensions: require initial for clause
noreply@sourceforge.net
noreply@sourceforge.net
Mon, 21 Aug 2000 19:52:04 -0700
Patch #101211 has been updated.
Project:
Category: None
Status: Closed
Summary: list comprehensions: require initial for clause
Follow-Ups:
Date: 2000-Aug-17 15:55
By: montanaro
Comment:
Description of the patch in the patch itself.
-------------------------------------------------------
Date: 2000-Aug-21 20:03
By: tim_one
Comment:
Skip, did you and/or Ping track down the problem you thought there might be with this? Or am I misremembering email? (Ironic note: we moved to the SF patch manager so discussions wouldn't get lost!)
-------------------------------------------------------
Date: 2000-Aug-21 21:14
By: montanaro
Comment:
Yes, Ping found and fixed the problem. The patch that I
submitted should do the right thing. I'm reassigning it to
Guido for his pronouncement. I believe it's ready to go.
(I am still pretty unclear on the sequence of events that
are required to take a patch from idea to cvs checkin...)
-------------------------------------------------------
Date: 2000-Aug-21 21:24
By: gvanrossum
Comment:
Thanks! To both of you. Also for the doc additions.
Skip, please check it in and then set the status to Closed.
When you submit a patch (or update one), it's best to leave it unassigned or assign it to the release manager (today still Tim, after tomorrow Jeremy).
If it *needs* BDFL pronouncement, the release manager will assign it to me with appropriate comments.
Note: the patch part for graminit.c failed -- you may want to run pgen again before you check it in.
-------------------------------------------------------
Date: 2000-Aug-21 21:29
By: tim_one
Comment:
Thanks, Skip! Have you read
http://python.sourceforge.net/sf-faq.html#a1
? If there's something about the patch process that wasn't answered there, let me know. I must say that, from my POV as "interim release manager" the past couple weeks, few people are playing along with the intent -- it's like nothing *moves* unless I step in to kick, prod or harass.
You assigning this to the person *you* believe should take the next step is exactly how it's supposed to work. Thanks for taking the initiative!
-------------------------------------------------------
Date: 2000-Aug-21 21:37
By: tim_one
Comment:
Assigned back to Skip since Guido Pronounced. Please feel free to check it in and Close it after addressing his comments.
-------------------------------------------------------
Date: 2000-Aug-21 21:39
By: tim_one
Comment:
AHA! A SourceForge insecurity: I'm deducing from the log that Guido changed the status to Accepted when he wrote his last comment, but I was writing a comment at the same time but without changing the status, and a submitted after he did. So ended up undoing his status change without knowing it! Changed Status back to Accepted.
-------------------------------------------------------
Date: 2000-Aug-21 22:52
By: montanaro
Comment:
changes have been checked in. Lib/test/test_parser.py breaks, but I forwarded a context diff to Fred Drake, who's been working on that module.
-------------------------------------------------------
-------------------------------------------------------
For more info, visit:
http://sourceforge.net/patch/?func=detailpatch&patch_id=101211&group_id=5470