[Patches] [Patch #101238] PyOS_CheckStack for Windows (MSVC)

[noreply@sourceforge.net]

Patch #101238 has been updated. 

Project: 
Category: core (C code)
Status: Closed
Summary: PyOS_CheckStack for Windows (MSVC)

Follow-Ups:

Date: 2000-Aug-21 17:11
By: tim_one

Comment:
Assigned to Guido because there's a policy issue.
This implements Jack's PyOS_CheckStack for the combo of Windows and MSVC.
The question is whether you think there's a general approach waiting to be had here (I don't, except for adopting Stackless), or whether platform-specific tricks are the best we can do.
-------------------------------------------------------

Date: 2000-Aug-21 18:16
By: gvanrossum

Comment:
The semantics of the stack are completely implementation dependent so I wouldn't know how to do this platform-independent.  This looks fine to me -- but when I test it (VC 6 on Win98), it doesn't work.  Try this:

class C:
  def __getattr__(self, a): return self.x

C()

This still aborts the program.

-------------------------------------------------------

Date: 2000-Aug-21 19:35
By: gvanrossum

Comment:
And are you sure you tested this?

As shown it breaks the build for _sre because the declaration for PyOS_CheckStack() doesn't use DL_IMPORT().  (MSVC 6.0 on Win98.)
-------------------------------------------------------

Date: 2000-Aug-23 07:06
By: effbot

Comment:
bumped stack margin to 8k on a 32-bit box (same as on the Macintosh).  this solves the __getattr__ problem, as well as bug #110615.

also: fixed the DL_IMPORT problem.
-------------------------------------------------------

Date: 2000-Aug-27 11:25
By: gvanrossum

Comment:
Thanks -- this works!  Check it in and close the patch please.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101238&group_id=5470