[Patches] [Patch #101482] fix for Bug #114245

noreply@sourceforge.net noreply@sourceforge.net
Sat, 30 Dec 2000 07:42:44 -0800


Patch #101482 has been updated. 

Project: python
Category: core (C code)
Status: Out of date
Submitted by: gangli59
Assigned to : mhammond
Summary: fix for Bug #114245 

Follow-Ups:

Date: 2000-Dec-30 07:42
By: loewis

Comment:
I had to mark this patch as out-of-date: when applying it to the current
CVS, it would patch the function in the wrong place. Please resubmit as a
context (-c) or unified (-u) diff. After you've updated the patch
(preferably addressing Mark's concerns in the process), please let me know
so I can reopen it.
-------------------------------------------------------

Date: 2000-Sep-16 16:18
By: tim_one

Comment:
Mark, does this look reasonable to you?  The thrust is to make utime work
for directories under Win32 (as well as for files).  THere's also an entry
for this one in PEP 42 (Feature Requests).

-------------------------------------------------------

Date: 2000-Sep-16 16:31
By: mhammond

Comment:
With a quick look and no decent analysis, I can't see a good reason why
this wouldnt work.  However, see
http://support.microsoft.com/support/kb/articles/q167/2/96.asp for the
official way of doing this - it is significantly different.

I have the above KB code all Python-ready, as it was used in the Windows CE
port.  I am happy to send this to anyone and everyone, but I am afraid I
don't have time to rework the patch.

Also note that I would _love_ to see whatever conversion routine you add
made public in the DLL (and hence named appropriately).  Windows CE could
use it, as could the Python Win32 extensions - keep the bloat size down by
keeping it in Python, and the cost of making it public isnt too bad!

-------------------------------------------------------

Date: 2000-Sep-16 19:40
By: nobody

Comment:
The time conversion function time2Time is modeled after MS C run time
library code. It looks official way of doing this also ;). However
UnixTimeToFileTime looks simpler. But I do not know if these two functions
do the same thing.
-------------------------------------------------------

Date: 2000-Sep-17 18:35
By: tim_one

Comment:
I changed this to Postponed:  the scope is growing, and the bug this is
related to was already changed to a Feature Request and added to PEP 42. 
Let's look at it again after 2.0final.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101482&group_id=5470