[Patches] openpty() and forkpty()

Thomas Wouters thomas@xs4all.net
Fri, 9 Jun 2000 17:51:23 +0200


On Fri, Jun 09, 2000 at 11:18:43AM -0400, Andrew M. Kuchling wrote:

> Anyway, the patch basically boils down to the following, which looks
> good.  With the addition of a patch to libposix.tex documenting the
> two new functions, I'd suggest checking it in.

Thanx. I have one comment though, something I didn't notice until after I
sent the patch in: posixmodule.c should include an include file for for the
prototype openpty/forkpty. Unfortunately, the actual file to include differs
between Linux and FreeBSD, and is nonexistant on BSDI. On Linux, it should
include pty.h, on FreeBSD libutil.h, and on BSDI there simply is no
prototype for openpty/forkpty to be found.

Should I make autoconf check for the existance of pty.h/libutil.h and
include other platforms seperately, once those get found, or should it just
provide the prototypes for openpty/forkpty itself ? The prototype does
match, on all three systems I am able to check.

-- 
Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!