[Patches] GC infrastructure patch 1 (tp_recurse, tp_clear)

Jeremy Hylton jeremy@beopen.com
Tue, 20 Jun 2000 17:52:51 -0400 (EDT)


Neil,

This patch defines the recurse function as 
typedef int (*recurseproc) Py_PROTO((PyObject *, visitproc, void *));

What is the return value for?  A number of the recurse functions
return 1 unless a call to visit fails.  Some return 1 even if a visit
call returns 0.  All of the visit functions in patch4 return 1.

It seems like it would make more sense to make it 
typedef void (*recurseproc) Py_PROTO((PyObject *, visitproc, void *));

Or to define the return values and be consistent about checking error
returns.

Jeremy