[Patches] Warnings in pythonrun.c

[Trent Mick]

On Thu, Jun 22, 2000 at 05:19:16PM +0200, Fredrik Lundh wrote:
> >
> > The appropriate place for this is in Include/import.h.

I apologize if I offended. I thought that the implied "I think" was
understood.

> 
> "appropriate" ?
> 
> if you'd bothered to look in Include/pythonrun.h, you'd found
> that _PyImport_Init was defined in that file, together with a
> whole bunch of other internal initializations and finalizations.
> 
> if you'd bothered to look in the CVS history, you'd found that
> _PyImport_Fini *was* declared in pythonrun.h, before someone
> accidentally removed it a few weeks ago.
> 

I suppose that I thought the best place for _PyImport_Anything was the
import.h|c files. That is how I would have built the system. However, you are
right, I did not note the convention of placing the Init/Fini declarations in
pythonrun.h. I will then second Tim's +1 to your patch.


This is what peer review is for.


Trent

-- 
Trent Mick
trentm@activestate.com