[Patches] warning in timemodule.c

[Peter Schneider-Kamp]

Greg Stein wrote:
> 
> Better Solution:
> change the declaration to "const char *s;"

The problem is that strptime returns an integer on my platform
(linux 2.2.13, glibc 2.1xx). What exactly is the function of the

#if 0
extern char *strptime(); /* Enable this if it's not declared in <time.h>
*/
#endif

?

> Type casts almost always hide underlying problems, rather than solving
> them. In this case, "s" was declared improperly.

That's right though.

> -1 on the type cast patch.
> +1 on changing the declaration of "s".

-1-on-changing-the-declaration-because-it-does-not-work-;-)-ly y'rs
Peter
--
Peter Schneider-Kamp          ++47-7388-7331
Herman Krags veg 51-11        mailto:peter@schneider-kamp.de
N-7050 Trondheim              http://schneider-kamp.de