[Patches] [Patch #102412] support for curses.setupterm

noreply@sourceforge.net noreply@sourceforge.net
Fri, 17 Nov 2000 16:08:21 -0800


Patch #102412 has been updated. 

Project: python
Category: Modules
Status: Open
Summary: support for curses.setupterm

Follow-Ups:

Date: 2000-Nov-16 13:20
By: mwh

Comment:
(oh dear; i'll be seeing that typo in my inbox then...)

i recently found myself wanting to use terminfo routines without the rest of curses.  _cursesmodule.c now sprouts tigetstr & friends, but demands you call initscr first (which i don't want to do).

this patch attempts to sort this out.  I'm not convinced that it's 100% the right approach - but I would like to sort this problem out.
-------------------------------------------------------

Date: 2000-Nov-17 15:11
By: akuchling

Comment:
Some comments:

* The setupterm wrapper should use the constants ERR and OK,
  not -1 and 0.

* Minor consistency nit: the rest of the code usually uses 'err' to hold error returns, not 'errret'.  (That's what the curs_terminfo man page uses, but I think I prefer this to be consistent.)

Make those two changes, and I approve the patch.

-------------------------------------------------------

Date: 2000-Nov-17 16:08
By: mwh

Comment:
this patch uses ERR slightly more, but still uses a literal -1 in the places man curs_terminfo does, and changes errret to err.  is that what you meant?

this patch also performs prunage on the list of unimplemented functions.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=102412&group_id=5470