[Patches] [Patch #101844] bdist_wininst creates corrupt installations

noreply@sourceforge.net noreply@sourceforge.net
Tue, 10 Oct 2000 06:14:33 -0700


Patch #101844 has been updated. 

Project: 
Category: distutils
Status: Open
Summary: bdist_wininst creates corrupt installations

Follow-Ups:

Date: 2000-Oct-09 11:13
By: theller

Comment:
[Martin von Loewis]
> I've created a PyXML distribution with recent distutils (0.93 and
> 1.0). When installing these distributions, the installer creates empty
> files only, see 
> 
> http://download.sourceforge.net/pyxml/PyXML-0.6.0.win32.exe
> 
> for an example.
> 
> I've tracked this down to usage of the zipfile module. If it does not
> find an external zip program (which I did not have), it then tries to
> use the zipfile module. Somehow, the installation program later cannot
> process the files created with that module.
> 
> The problem is probably in the installer, since Winzip 7 is capable of
> reading the package, and extracts the files properly.
> 
> I have solved the problem by installing infozip on my
> machine. However, I'd appreciate if somebody could look into the
> problem and let me know what the cause is. If you cannot reproduce the
> problem, please let me know as well.
> 
The problem was that the windows installer was using zipfile datastructures
which are not always set.
The following patch fixes this problem.
Since currently I cannot check in these changes, I'm posting them here
so they do not get lost.
Note that wininst.exe must be recompiled and bdist_wininst.py
must be regenerated to complete the fix.

Thomas
-------------------------------------------------------

Date: 2000-Oct-09 12:28
By: gvanrossum

Comment:
Hopefully Greg Ward will eb back to review this before 2.0 *final* goes out on Oct 16.
-------------------------------------------------------

Date: 2000-Oct-09 12:54
By: akuchling

Comment:
Greg is supposed to be getting back around Friday the 13th.  (Hmmm...)  So the schedule will be tight, but I don't think Greg can do much checking on the Windows install; since the patch is from Thomas, he'll probably just trust it.

-------------------------------------------------------

Date: 2000-Oct-09 13:44
By: jhylton

Comment:
Thomas,

I have no idea how to apply this patch.  I can't find the files mentioned anywhere in the Python CVS tree.


-------------------------------------------------------

Date: 2000-Oct-09 13:58
By: jhylton

Comment:
AMK points out that this is a patch against some distutils source tree stored elsewhere.  The code it patches is included as a base64 encoded string in the Python code.  Wow!  The sheer vulgarity of this impresses me.

I think we should integrate the actual source code into the CVS tree when Greg gets back.

-------------------------------------------------------

Date: 2000-Oct-09 16:37
By: loewis

Comment:
Please note that the patch fixes a problem that *only* occurs if you are using the bdist_wininst command of distutils (i.e. if you are the owner of a package and you want to produce Windows installers), and only if you do not have an external zip.exe. I feel users of Python 2.0 could live with this bug, if it was documented that they either need infozip or distutils 1.1 (which hopefully will contain the fix as well).
-------------------------------------------------------

Date: 2000-Oct-10 06:14
By: theller

Comment:
Please see the comments I posted to python-dev:
http://www.python.org/pipermail/python-dev/2000-October/016540.html
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=101844&group_id=5470