[Patches] [ python-Patches-401606 ] threads and __del__

noreply@sourceforge.net noreply@sourceforge.net
Thu, 09 Aug 2001 09:10:04 -0700


Patches item #401606, was opened at 2000-09-22 07:47
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=401606&group_id=5470

Category: core (C code)
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: Toby Dickenson (htrd)
Assigned to: Martin v. Löwis (loewis)
Summary: threads and __del__

Initial Comment:
 

----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2001-08-09 09:10

Message:
Logged In: YES 
user_id=6380

In that case I'll reject and close it. 


----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2001-08-09 09:03

Message:
Logged In: YES 
user_id=31435

See bug 215076 for discussion.  It's unclear what this 
believes it's solving, so also unclear that it actually 
solves it.  It does complicate *our* code, and the patch 
adds no comments explaining why this convolution is 
necessary (so if this does solve something, it's likely to 
break again anyway, as nobody reading the code will 
understand why it's so complicated).  The relationship 
between threads and __del__ should either be left alone, or 
defined carefully (like in a PEP).

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-08-09 08:48

Message:
Logged In: YES 
user_id=6380

Looks good to me.  The patch to pystate.c doesn't apply
cleanly, but it appears to be a benign conflict.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-06-04 00:47

Message:
Logged In: YES 
user_id=21627

I recommend to approve this patch.


----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2000-09-22 08:06

Message:
Works fine for me.
Assigned to Tim for review since he's the race condition czar.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=401606&group_id=5470