[Patches] [ python-Patches-449367 ] HTTPS client authentication in httplib

[noreply@sourceforge.net]

Patches item #449367, was opened at 2001-08-08 19:14
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=449367&group_id=5470

Category: library
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: George Yang (gyang)
Assigned to: Greg Stein (gstein)
Summary: HTTPS client authentication in httplib

Initial Comment:
HTTPS is different from HTTP only by:
--connection_class
In HTTP.__Init__:
the old code use
self._connection_class(host, port)

It fails to pass the x509 argument to the
HTTPSConnection, which makes SSL client authentication
fails.

So, it should be
self._connection_class(host, port, **x509)


----------------------------------------------------------------------

>Comment By: Greg Stein (gstein)
Date: 2001-08-18 02:23

Message:
Logged In: YES 
user_id=6501

I resolved this a bit differently, to prevent the **x509 
from being attached to HTTPConnection (which would allow 
arbitrary params where there shouldn't be).

----------------------------------------------------------------------

Comment By: Greg Stein (gstein)
Date: 2001-08-09 12:34

Message:
Logged In: YES 
user_id=6501

Seems reasonable at first glance. I'll handle this next 
week with the other HTTP/proxy/DAV work.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-08-09 06:25

Message:
Logged In: YES 
user_id=6380

Greg, what he says seems to make sense, but I dun't
understand the code enough -- and I thought that https://
URLs actually worked, so I'm not sure when they don't work. 
Can you review the patch and check it in if it's right?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=449367&group_id=5470