[Patches] [ python-Patches-491351 ] Changes static strcpy to memcpy

noreply@sourceforge.net noreply@sourceforge.net
Tue, 11 Dec 2001 10:55:23 -0800


Patches item #491351, was opened at 2001-12-10 15:12
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=491351&group_id=5470

Category: Core (C code)
Group: Python 2.3
Status: Open
Resolution: None
Priority: 5
Submitted By: David Jacobs (dbj)
Assigned to: Nobody/Anonymous (nobody)
Summary: Changes static strcpy to memcpy

Initial Comment:
This patch replaces all occurrances in the codebase of 
calls to strcpy that use static strings with calls to 
memcpy (e.g., strcpy(a, "a string") gets replaced with 
memcpy(a, "a string", 9))

David Jacobs
jacobsl001@hawaii.rr.com  

----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-11 10:55

Message:
Logged In: YES 
user_id=6380

My thoughts exactly. This causes a maintenance nightmare,
for no good reason. It's not like this mechanical
translation plugs any security leaks either... At best it
silences naive security tools that complain about every
strcpy() call they see. But that's not my problem.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-12-11 10:21

Message:
Logged In: YES 
user_id=21627

What is the rationale for this patch? Maintaining the memcpy
calls is much more complicated and error-prone.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=491351&group_id=5470