[Patches] [ python-Patches-491736 ] Eliminate redundant code in PyString_Fro

noreply@sourceforge.net noreply@sourceforge.net
Tue, 11 Dec 2001 13:31:22 -0800


Patches item #491736, was opened at 2001-12-11 13:19
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=491736&group_id=5470

Category: Core (C code)
Group: Python 2.3
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: David Jacobs (dbj)
Assigned to: Nobody/Anonymous (nobody)
Summary: Eliminate redundant code in PyString_Fro

Initial Comment:
stringobject.c  - revision 2.147

Realized that PyString_FromString replicates the code 
from PyString_FromStringAndSize so I thought 
maintenance would be improved by calling 
PyString_FromStringAndSize instead of duplicating the 
code.

If patches like these are considered a nusuiance 
please let me know and I'll stop and only submit bug 
patches.  I am still trying to learn what kinds of 
contributions this community like to receive :-).  I 
find doing things like this helps me learn a new 
codebase.

Thanks for you time,
David

----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-11 13:31

Message:
Logged In: YES 
user_id=6380

In this particular case there's a documented need to squeeze
as much performance out of the CPU as desired, hence the
code duplication.

Keep on trying, you'll find something that's useful!

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=491736&group_id=5470