[Patches] [ python-Patches-494100 ] warn about $(CONFINCLUDEPY)/config.h

noreply@sourceforge.net noreply@sourceforge.net
Mon, 17 Dec 2001 12:38:22 -0800


Patches item #494100, was opened at 2001-12-16 23:29
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=494100&group_id=5470

Category: Build
Group: Python 2.3
>Status: Closed
>Resolution: Wont Fix
Priority: 4
Submitted By: Skip Montanaro (montanaro)
Assigned to: Nobody/Anonymous (nobody)
Summary: warn about $(CONFINCLUDEPY)/config.h

Initial Comment:
During install, the user should probably be warned
if 
$(CONFINCLUDEPY)/config.h is found, as it's likely
to be out-of-
date.  Here's a simple patch for
Makefile.pre.in.

S


----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-17 12:38

Message:
Logged In: YES 
user_id=6380

It was config.h in 2.1 and before (as well as in 2.1.1 and
2.1.2).

I thought this was inspired by something that had happened
to you? But since the include directory's name includes the
python version, I agree that it's not likely to fine a
config.h there unless you downloaded early 2.2 alpha
releases...

Closing now.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2001-12-17 12:32

Message:
Logged In: YES 
user_id=44345

I'm cool with just deleting the file.  I guess it's best
to simply break 
bad builds in an obvious way instead of
the subtle way that leaving it 
alone would.

On the other hand, will the system ever find a config.h 
in
/usr/local/lib/python2.2?  Wasn't the name changed 
to
pyconfig.h before the 2.2 cycle began?  Maybe this isn't
such a 
useful idea.

Skip


----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-12-17 06:04

Message:
Logged In: YES 
user_id=6380

Good idea. I have no problem with you checking this in, but
I doubt it will be effective: "make install" prints so much
output that it will be ignored when it's most important.
Maybe you can just delete the config.h???

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=494100&group_id=5470