[Patches] [Patch #103930] Ignore error making grammar src if srcdir is readonly

noreply@sourceforge.net noreply@sourceforge.net
Thu, 22 Feb 2001 08:20:48 -0800


Patch #103930 has been updated. 

Project: python
Category: Build
Status: Open
Submitted by: nascheme
Assigned to : nascheme
Summary: Ignore error making grammar src if srcdir is readonly

Follow-Ups:

Date: 2001-Feb-22 08:20
By: twouters

Comment:

This doesn't look like it does what it is supposed to. At least, after
applying the patch, Grammar doesn't get rebuilt at all, even when
graminit.h is missing:

gcc -D_HAVE_BSDI -c -g -O2 -Wall -Wstrict-prototypes -I. -I../Include
-DHAVE_CONFIG_H  -o Python/compile.o ../Python/compile.c
../Python/compile.c:17: graminit.h: No such file or directory

I can't seem to get it to make it, even though there is a $(GRAMINIT_H)
dependancy. 'make Include/graminit.h' no longer works, and neither does
anything else I can come up with.

But I'd like to note I'm still against rebuilding the Grammar automatically
in releases :-) I'm not really sure if it's still worth rebuilding the
Grammar each time, myself. It was when I did the original (horribly broken)
patch, but that was in the heat of 2.0, with lots of Grammar-changing
patch-proposals about.

-------------------------------------------------------

Date: 2001-Feb-21 05:43
By: nascheme

Comment:
Does this make sense?  My last change making graminit.h
and graminit.c in the build directory was wrong.  The
compiler does not understand VPATH so the include
file could not be found.  The new idea is to continue the
build even if the grammar sources cannot be regenerated
(maybe the source directory is readonly).  I don't want
to remove the target completely since someone may change
the grammar and forget to generate the source.
-------------------------------------------------------

-------------------------------------------------------
For more info, visit:

http://sourceforge.net/patch/?func=detailpatch&patch_id=103930&group_id=5470