[Patches] [ python-Patches-403495 ] case sensitive import for case insensitive FileSystem

[nobody]

Artifact #403495, was updated on 2001-01-29 15:53
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=403495&group_id=5470

Category: core (C code)
Group: None
Status: Closed
Priority: 5
Submitted By: Steven D. Majewski
Assigned to: Barry Warsaw
Summary: case sensitive import for case insensitive FileSystem

Initial Comment:
Here's a patch that fixes the case insensitive import 
problem on MacOSX. It's not a mac-specific patch -- just
requires HAVE_DIRENT_H, but I'm not sure if anyone not on
MacOSX would want it. ( Even if you're using a mac HFS 
filesystem from LinuxPPC, I don't think you're going to
install Python on it! ) or maybe there should be a config 
flag or including it?  I'm not sure what preprocessor 
symbols could be used to determine macosx. __APPLE__ is
predefined, but I don't know if this is also defined for
non-bsd "classic" macos. 

( I guess __APPLE__ & HAVE_DIRENT_H should work. ) 

-- Steve Majewski


----------------------------------------------------------------------

Comment By: Barry Warsaw
Date: 2001-02-26 08:56

Message:
Logged In: YES 
user_id=12800

Closing, since this patch was applied.  At least I'm pretty
sure it was -- hard to tell since SF seems to have
regenerated all new patch numbers. :(


----------------------------------------------------------------------

Comment By: Tim Peters
Date: 2001-02-16 21:41

Message:
Reassigning to Barry since he marked it Accepted, and changing it to Open because I *think* it's already been applied.  Barry, if you did apply it, mark it as Closed.

----------------------------------------------------------------------

Comment By: Barry Warsaw
Date: 2001-02-02 11:09

Message:
Whoops!  Marking as accepted.

----------------------------------------------------------------------

Comment By: Barry Warsaw
Date: 2001-02-02 11:08

Message:
Here's a version of the patch that applies cleanly to the 2.1a2 source, conforms to C coding styles, and builds on Linux RH 6.1.  It passes regrtest and "import getpass" (termios/TERMIOS).

I cannot test it on any other platform.  I'm marking this as accepted and commiting it to the 2.1a2 tree.  Once other platforms have verified that it works for them, we can close the patch.

----------------------------------------------------------------------

Comment By: Jason Tishler
Date: 2001-02-01 06:47

Message:
Scratch the comment about the bug -- I've too much C++ on the head to
think in straight C anymore.

----------------------------------------------------------------------

Comment By: Jason Tishler
Date: 2001-01-31 18:20

Message:
Guido, Do you find the style of this patch more acceptable than mine (103154)?  If so, would
you consider including a cleaned up version into 2.1a2?  Note that I have found one bug
(MatchFilename() does not handle a NULL pathname correctly) and the code should probably
be enabled on something more specific than HAVE_DIRENT_H (e.g., platform #defs,
UNIX_STYLE_CHECK_IMPORT_CASE, etc).

----------------------------------------------------------------------

Comment By: Steven D. Majewski
Date: 2001-01-29 20:30

Message:
Oops!
The previous patch crashes if the path is empty,
which is the case for the current directory.
Added a line to check for that and use "." 
instead on diropen. 

-- Steve M.

----------------------------------------------------------------------

Comment By: Steven D. Majewski
Date: 2001-01-29 20:27

Message:
Oops!
The previous patch crashes if the path is empty,
which is the case for the current directory.
Added a line to check for that and use "." 
instead on diropen. 

-- Steve M.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=403495&group_id=5470