[Patches] [ python-Patches-404282 ] Manifest.in not included in sdist...

[nobody]

Patches #404282, was updated on 2001-02-26 05:36
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=404282&group_id=5470

Category: distutils
Group: None
Status: Closed
Priority: 5
Submitted By: Rene Liebscher
Assigned to: A.M. Kuchling
Summary: Manifest.in not included in sdist...

Initial Comment:
The sdist command includes some files in MANIFEST
without you to have specify them (setup.py, README)
(The use_defaults option is on by default.)

If you create MANIFEST from MANIFEST.IN 
then it should also include MANIFEST.IN.

(see also
http://mail.python.org/pipermail/distutils-sig/2000-October/001685.html
)

This patch adds the template file if it is used and
use_defaults is on.

-------------------------------------------------------
Index: distutils/command/sdist.py
===================================================================
RCS file:
/cvsroot/python/distutils/distutils/command/sdist.py,v
retrieving revision 1.51
diff -c -r1.51 sdist.py
*** distutils/command/sdist.py  2000/10/14 04:06:40    
1.51
--- distutils/command/sdist.py  2001/02/26 13:27:48
***************
*** 244,249 ****
--- 244,251 ----
              # Read manifest template if it exists
              if template_exists:
                  self.read_template()
+                 if self.use_defaults: # don't forget
MANIFEST.in
+                    
self.filelist.append(self.template)
  
              # Prune away any directories that don't
belong in the source
              # distribution


----------------------------------------------------------------------

Comment By: A.M. Kuchling
Date: 2001-02-27 10:57

Message:
Logged In: YES 
user_id=11375

I don't think I like this patch, because it means figuring
out which files are added by setting .use_defaults
If you already have a MANIFEST.in, why not just add a
'include MANIFEST.in' to it?

Comment boxes on SF have always swallowed the whitespace;
patches should always be provided as an uploaded file.


----------------------------------------------------------------------

Comment By: Rene Liebscher
Date: 2001-02-26 05:38

Message:
Logged In: YES 
user_id=28463

Where are the blanks?

(see 
http://mail.python.org/pipermail/distutils-sig/2000-October/001693.html 
for a correct indentation)

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=404282&group_id=5470