[Patches] [ python-Patches-404680 ] Two more Cygwin standard module issues
nobody
nobody@sourceforge.net
Tue, 27 Feb 2001 14:54:33 -0800
Patches #404680, was updated on 2001-02-27 12:19
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=404680&group_id=5470
Category: Build
Group: None
Status: Closed
Priority: 5
Submitted By: Jason Tishler
Assigned to: A.M. Kuchling
Summary: Two more Cygwin standard module issues
Initial Comment:
This patch disables the nis module and enables the dl module when building under Cygwin.
Use patch -p0 <cygwin.patch to apply.
I apologize for not catching these earlier. Sigh...
----------------------------------------------------------------------
Comment By: Tim Peters
Date: 2001-02-27 14:54
Message:
Logged In: YES
user_id=31435
I just tried to upload a file (SSL mode; IE 5.5; but behind
my ISP's proxy), and it just yields an "Error -- nothing
changed" msg. Trying again while also adding this comment.
----------------------------------------------------------------------
Comment By: Jason Tishler
Date: 2001-02-27 14:23
Message:
Logged In: YES
user_id=86216
I wasn't in SSL mode before, so I try, try again...
----------------------------------------------------------------------
Comment By: A.M. Kuchling
Date: 2001-02-27 14:21
Message:
Logged In: YES
user_id=11375
Attaching a config.py...
----------------------------------------------------------------------
Comment By: Jason Tishler
Date: 2001-02-27 14:21
Message:
Logged In: YES
user_id=86216
It worked for bigdisk -- will it work for me?
----------------------------------------------------------------------
Comment By: A.M. Kuchling
Date: 2001-02-27 14:21
Message:
Logged In: YES
user_id=11375
Attaching a file... again.
----------------------------------------------------------------------
Comment By: Tim Perdue
Date: 2001-02-27 14:16
Message:
Logged In: YES
user_id=858
Attaching a file...
----------------------------------------------------------------------
Comment By: A.M. Kuchling
Date: 2001-02-27 12:54
Message:
Logged In: YES
user_id=11375
Accepted and checked in.
----------------------------------------------------------------------
Comment By: Jason Tishler
Date: 2001-02-27 12:49
Message:
Logged In: YES
user_id=86216
Is my pasted version usable? The email that I received
seems to indicate that it is.
BTW, I noticed your futile attempts too.
----------------------------------------------------------------------
Comment By: A.M. Kuchling
Date: 2001-02-27 12:45
Message:
Logged In: YES
user_id=11375
I just tried uploading a patch, and it doesn't seem to work
at all. Will report this to SF...
----------------------------------------------------------------------
Comment By: Jason Tishler
Date: 2001-02-27 12:41
Message:
Logged In: YES
user_id=86216
I guess that attaching patches no longer works or
there is some kind of user error on my part...
See the following for the pasted patch:
Index: setup.py
===================================================================
RCS file: /cvsroot/python/python/dist/src/setup.py,v
retrieving revision 1.30
diff -c -r1.30 setup.py
*** setup.py 2001/02/23 16:32:32 1.30
--- setup.py 2001/02/27 20:04:45
***************
*** 387,398 ****
exts.append( Extension('dl', ['dlmodule.c']) )
# Sun yellow pages. Some systems have the functions in libc.
! if (self.compiler.find_library_file(lib_dirs, 'nsl')):
! libs = ['nsl']
! else:
! libs = []
! exts.append( Extension('nis', ['nismodule.c'],
! libraries = libs) )
# Curses support, requring the System V version of curses, often
# provided by the ncurses library.
--- 387,399 ----
exts.append( Extension('dl', ['dlmodule.c']) )
# Sun yellow pages. Some systems have the functions in libc.
! if platform not in ['cygwin']:
! if (self.compiler.find_library_file(lib_dirs, 'nsl')):
! libs = ['nsl']
! else:
! libs = []
! exts.append( Extension('nis', ['nismodule.c'],
! libraries = libs) )
# Curses support, requring the System V version of curses, often
# provided by the ncurses library.
Index: Lib/test/test_dl.py
===================================================================
RCS file: /cvsroot/python/python/dist/src/Lib/test/test_dl.py,v
retrieving revision 1.10
diff -c -r1.10 test_dl.py
*** Lib/test/test_dl.py 2001/01/17 21:51:35 1.10
--- Lib/test/test_dl.py 2001/02/27 20:04:58
***************
*** 9,14 ****
--- 9,15 ----
sharedlibs = [
('/usr/lib/libc.so', 'getpid'),
('/lib/libc.so.6', 'getpid'),
+ ('/usr/bin/cygwin1.dll', 'getpid'),
]
for s, func in sharedlibs:
Index: Modules/dlmodule.c
===================================================================
RCS file: /cvsroot/python/python/dist/src/Modules/dlmodule.c,v
retrieving revision 2.16
diff -c -r2.16 dlmodule.c
*** Modules/dlmodule.c 2001/02/22 15:52:55 2.16
--- Modules/dlmodule.c 2001/02/27 20:05:06
***************
*** 134,140 ****
static PyTypeObject Dltype = {
! PyObject_HEAD_INIT(&PyType_Type)
0, /*ob_size*/
"dl", /*tp_name*/
sizeof(dlobject), /*tp_basicsize*/
--- 134,140 ----
static PyTypeObject Dltype = {
! PyObject_HEAD_INIT(NULL)
0, /*ob_size*/
"dl", /*tp_name*/
sizeof(dlobject), /*tp_basicsize*/
***************
*** 199,205 ****
Py_XDECREF(v);
}
! void
initdl(void)
{
PyObject *m, *d, *x;
--- 199,205 ----
Py_XDECREF(v);
}
! DL_EXPORT(void)
initdl(void)
{
PyObject *m, *d, *x;
***************
*** 210,215 ****
--- 210,218 ----
"module dl requires sizeof(int) == sizeof(long) == sizeof(char*)");
return;
}
+
+ /* Initialize object type */
+ Dltype.ob_type = &PyType_Type;
/* Create the module and add the functions */
m = Py_InitModule("dl", dl_methods);
----------------------------------------------------------------------
Comment By: Jason Tishler
Date: 2001-02-27 12:35
Message:
Logged In: YES
user_id=86216
I am attaching the patch again. Note that this is the
first time that I have uploaded a patch since the change
to SF. Does uploading patches instead of pasting stil
work?
----------------------------------------------------------------------
Comment By: A.M. Kuchling
Date: 2001-02-27 12:22
Message:
Logged In: YES
user_id=11375
Umm... there doesn't seem to be a patch attached.
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=404680&group_id=5470