[Patches] [ python-Patches-436258 ] Some cleanup of the cPickle module

[noreply@sourceforge.net]

Patches item #436258, was opened at 2001-06-25 20:01
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=436258&group_id=5470

Category: Modules
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Robert Minsk (rminsk)
Assigned to: Fred L. Drake, Jr. (fdrake)
Summary: Some cleanup of the cPickle module

Initial Comment:
While getting rid of compiler warning messages for
another non-gcc compiler I found some dead code in
cPickle.c.  The attached patch fixes some possible
type casting problems and removed some dead code.

----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-17 12:12

Message:
Logged In: YES 
user_id=3066

Thanks!  Please don't hesitate to report any additional
warnings that crop up; I don't expect we'll have access to
SGI hardware any time soon.

----------------------------------------------------------------------

Comment By: Robert Minsk (rminsk)
Date: 2001-07-17 12:06

Message:
Logged In: YES 
user_id=132786

The SGI 7.3.1.2m with the -fullwarn option turned on.  I
always compile with
fullwarnings and try to get rid of what i can...

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-17 11:35

Message:
Logged In: YES 
user_id=3066

Checked in as Modules/cPickle.c revision 2.60.  (I'm still
curious as to which compiler generated the warnings, though.)

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-17 11:15

Message:
Logged In: YES 
user_id=3066

Looks reasonable.  Which compiler reported problems?

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=436258&group_id=5470