[Patches] [ python-Patches-429136 ] BROWSER fix for webbrowser.py

noreply@sourceforge.net noreply@sourceforge.net
Wed, 18 Jul 2001 16:40:26 -0700


Patches item #429136, was opened at 2001-05-31 13:29
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=429136&group_id=5470

Category: library
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Skip Montanaro (montanaro)
Assigned to: Skip Montanaro (montanaro)
Summary: BROWSER fix for webbrowser.py

Initial Comment:
webbrowser.py currently assumes the BROWSER environment
variable was set by the user who will take care of
registering that browser.  In the case of
Gnome+Mandrake 8.0 (at least), this is not the case. 
The attached patch attempts to register any browsers
found in BROWSER that aren't in the _browser dict
already.


----------------------------------------------------------------------

>Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-18 16:40

Message:
Logged In: YES 
user_id=3066

Actually, it was 1.18.2.1 in the maintenance branch.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2001-07-18 16:15

Message:
Logged In: YES 
user_id=44345

checked in on release21-maint branch (v1.19).  Closing
again...

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-18 14:42

Message:
Logged In: YES 
user_id=3066

Assigning back to Skip for checkin on the release21-maint
branch.  Please checkin and close.

Thanks!

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2001-07-18 14:39

Message:
Logged In: YES 
user_id=44345

I think it should be.  Without it, on systems running Gnome,
the webbrowser module doesn't work.  In particular, note
that the 2.1 version of webbrowser.py made the (incorrect)
assumption that the user would be the only person setting
the BROWSER environment variable.  If you eliminate that
assumption, you have to assume that the user may not have
registered all the browsers mentioned in BROWSER.

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-18 13:08

Message:
Logged In: YES 
user_id=3066

Hmm... should this be part of the 2.1.1 release as well? 
It's not clear to me whether this is strictly a bugfix. 
Re-opening and assigning to Thomas for a ruling.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2001-07-18 13:04

Message:
Logged In: YES 
user_id=44345

checked in  this change as v 1.19 of webbrowser.py


----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-18 11:53

Message:
Logged In: YES 
user_id=3066

Accepted; please check this in.

----------------------------------------------------------------------

Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-03 22:25

Message:
Logged In: YES 
user_id=3066

Assigned to me, since the webbrowser module is largely my
fault, and the initialization has become more complex than
it needs to be anyway.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=429136&group_id=5470