[Patches] [ python-Patches-411138 ] Fix for #231774: pyconfig.h
noreply@sourceforge.net
noreply@sourceforge.net
Thu, 26 Jul 2001 13:19:21 -0700
Patches item #411138, was opened at 2001-03-25 00:30
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=411138&group_id=5470
Category: Build
Group: None
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Martin v. Löwis (loewis)
Assigned to: Martin v. Löwis (loewis)
Summary: Fix for #231774: pyconfig.h
Initial Comment:
This patch renames config.h to pyconfig.h, to allow
autoconfiscation of python-based projects.
In addition to the changes collected in this patch, the
following actions are required when committing it:
- re-run autoheader and autoconf
- cvs add pyconfig.h (generated by autoheader), cvs
remove config.h
- rename PC/config.h, PC/os2vacpp/config.h, and
RISCOS/config.h in CVS (probably using cvs add/remove)
- globally replace config.h in PC/os2vacpp/makefile and
PC/os2vacpp/makefile.omk; this change has been omitted
from the patch because it is quite large.
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2001-07-26 06:57
Message:
Logged In: YES
user_id=21627
Committed as
Makefile.pre.in 1.45
config.h.in delete
configure 1.228
configure.in 1.236
pyconfig.h.in 1.1
ext.tex 1.101
libexcs.tex 1.40
libsys.tex 1.51
Python.h 2.36
pgenheaders.h 2.25
pyport.h 2.28
cygwinccompiler.py 1.13
sysconfig.py 1.38
build_ext.py 1.75
Porting 3.2
_testcapimodule.c 1.10
getbuildinfo.c 2.7
posixmodule.c 2.195
config.h delete
dl_nt.c 1.4
pyconfig.h 1.1
config.h delete
makefile 1.4
makefile.omk 1.2
pyconfig.h 1.1
python20.wse 1.43
atof.c 2.8
fmod.c 2.14
getmtime.c 2.17
hypot.c 2.4
pyfpe.c 2.7
strtod.c 1.11
thread.c 2.37
config.h delete
pyconfig.h 1.1
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2001-07-26 06:24
Message:
Logged In: YES
user_id=6380
I disagree with Thomas -- for the *users* of the file, the
fact that it was generated by autoconf is irrelevant, but
the fact that it belongs to Python is.
Martin, please go ahead and apply this (if it still works).
----------------------------------------------------------------------
Comment By: Thomas Wouters (twouters)
Date: 2001-07-26 05:52
Message:
Logged In: YES
user_id=34209
I honestly don't care which gets applied (I forget if there
was any real difference in the patches anyway, except that
mine didn't touch distutils) though I do think something
that says "autoconf configuration" rather than "python
configuration" would be better. But then again, it's not
like it really matters :)
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2001-07-25 23:51
Message:
Logged In: YES
user_id=21627
I still think my patch should be applied as-is, following
the instructions above.
----------------------------------------------------------------------
Comment By: Fred L. Drake, Jr. (fdrake)
Date: 2001-07-25 14:58
Message:
Logged In: YES
user_id=3066
Martin/Thomas: do you two still want to see one of these patches applied for 2.2? Which of the two patches makes the most sense to you?
----------------------------------------------------------------------
Comment By: Martin v. Löwis (loewis)
Date: 2001-04-11 09:01
Message:
Logged In: YES
user_id=21627
I have created this patch because I was not aware of the
other one; the bug #231774 log did not indicate that a patch
was in progress. As for the specific differences between
them: I like pyconfig.h better than pyac_config.h. The file
object chunk was there by mistake; I have removed it.
I don't think that the distutils as shipped with Python need
to check for config.h, since the Python release having this
version of distutils will use only pyconfig.h. For
independent distutils releases, looking for config.h might
be necessary.
I also don't think that the documentation should mention
config.h; Python documentation was always accurate only for
the release in which it was included.
----------------------------------------------------------------------
Comment By: Thomas Wouters (twouters)
Date: 2001-04-11 05:40
Message:
Logged In: YES
user_id=34209
I may be biased, but I don't see the difference between this
patch and my patch, except that there are some errors in
this patch :) It includes a change in fileobject.h that
isn't supposed to be there (I think), and it changes
distutils in the wrong way (distutils, for backward
compatibility, should check for both config.h and
pyconfig.h) -- though my patch doesn't address the latter
issue, it doesn't touch distutils at all.
Documentation should also mention both config.h and
pyconfig.h. Other than that, I don't care which patch gets
accepted, by the way :) But maybe Martin can explain why he
created this patch ?
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2001-04-10 15:11
Message:
Logged In: YES
user_id=6380
PS. Does this supersede patch #403978?
----------------------------------------------------------------------
Comment By: Guido van Rossum (gvanrossum)
Date: 2001-04-10 15:09
Message:
Logged In: YES
user_id=6380
Let's do this after 2.1.
----------------------------------------------------------------------
You can respond by visiting:
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=411138&group_id=5470