[Patches] [ python-Patches-403640 ] incomplete proxy handling in URLLIB

[noreply@sourceforge.net]

Patches item #403640, was updated on 2001-02-06 06:57
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=403640&group_id=5470

Category: library
Group: None
Status: Open
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: Guido van Rossum (gvanrossum)
Summary: incomplete proxy handling in URLLIB

Initial Comment:
under WinNT, the proxy code takes the proxy values from the registry, but does *not* check for the proxy override settings. The supplied patch does take care of it and works for me. Not very sophisticated, but operational.

----------------------------------------------------------------------

>Comment By: Tim Peters (tim_one)
Date: 2001-03-17 21:23

Message:
Logged In: YES 
user_id=31435

Back to you!  I've spent enough time on it, but I don't 
know this code, and it turns out I never get into it 
anyway.  @Home uses the AutoConfigURL registry gimmick 
rather than ProxyEnable (which is 0 on my box) and 
ProxyOverride (which doesn't exist on my box).

Even if they did exist, the new proxy_bypass() routine 
isn't called if the url passed to open_http() is a string, 
and it always is a string for me.  Trying to trace *that* 
back, this is apparently because the NT getproxies() 
function returns {}, and again because @Home isn't enabling 
ProxyEnable.

So best I can say is that this code doesn't hurt me.

Note that there are jarring style differences with 
surrounding code, primarily use of Capitalized words for 
local vrbl names.  Also lines and comments spilling past 
column 80.  The list() call in

list(proxyOverrd.split(';'))

doesn't appear to make sense (.split() returns a list!).  
For that matter proxyOverrd is an ugly abbreviation.

----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-03-01 23:07

Message:
Logged In: YES 
user_id=6380

Tim, you seem to be using a proxy, so maybe you can give
this a try?
Also, it has Win specific code (_winreg usage).

If you can't or don't want to, please give it back.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=403640&group_id=5470