[Patches] [ python-Patches-410395 ] death module

[noreply@sourceforge.net]

Patches item #410395, was updated on 2001-03-21 14:29
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=410395&group_id=5470

Category: Modules
Group: None
Status: Open
Priority: 3
Submitted By: Jeremy Hylton (jhylton)
>Assigned to: Jeremy Hylton (jhylton)
Summary: death module

Initial Comment:
This module makes it easy to generate core dumps from
Python.


----------------------------------------------------------------------

>Comment By: Barry Warsaw (bwarsaw)
Date: 2001-03-21 14:40

Message:
Logged In: YES 
user_id=12800

Looks good, a few comments.

- the deathmodule.c patch was included three times!  Guess
you really want it to die.

- you should include a death_die_abort() which calls the
abort() function.

- the functions return NULL but don't set an exception. 
while I agree it's highly unlikely <wink> that the functions
actually return, you might want to do something saner than
cause a SystemError if they magically manage to return on
some platform.
- be sure that this module isn't built/enabled by default! 
if an app had a hole which allowed this module to be
invoked, it would be a nice DoS attack.

- you may want to coordinate a bit with Dave Beazley based
on his IPC9 presentation.

Assigning back to Jeremy with a +1.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=410395&group_id=5470