[Patches] [ python-Patches-476612 ] Make md5/sha/hmac match PEP 247

[noreply@sourceforge.net]

Patches item #476612, was opened at 2001-10-30 18:41
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=476612&group_id=5470

Category: Modules
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: A.M. Kuchling (akuchling)
>Assigned to: A.M. Kuchling (akuchling)
Summary: Make md5/sha/hmac match PEP 247

Initial Comment:
This patch makes the interfaces of the md5, sha, and 
hmac modules match that described in PEP 247.  
For md5 and sha, the patch just adds digest_size 
attributes (in addition to the existing digestsize 
:().  For hmac it does the same, and also makes the 
.copy() method work.

The patch to hmac.py should be reviewed by Gerhard 
Haring; the other bits of the patch are trivial and 
just need a quick skim from someone to catch any 
dopey thinkos.



----------------------------------------------------------------------

>Comment By: Neil Schemenauer (nascheme)
Date: 2001-11-02 13:30

Message:
Logged In: YES 
user_id=35752

Looks good to me.


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2001-11-02 12:12

Message:
Logged In: YES 
user_id=11375

Randomly assigning to Neil for a quick skim.  (Don't 
bother proofreading the hmac.py changes; the original 
author has a different patch.)


----------------------------------------------------------------------

Comment By: Gerhard Häring (ghaering)
Date: 2001-11-01 15:54

Message:
Logged In: YES 
user_id=163326

I've reviewed the hmac changes. Unfortunately, the copy 
method was more broken than you thought ;-) I've fixed 
this in patch #477336 and also submitted an extensive 
testsuite for hmac there.

This patch also contains your changes to hmac.py.


----------------------------------------------------------------------

Comment By: A.M. Kuchling (akuchling)
Date: 2001-10-30 18:44

Message:
Logged In: YES 
user_id=11375

Attaching Lib/test/test_pep247.py, which checks the three 
included hashing modules for compliance with PEP247.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=476612&group_id=5470