[Patches] [ python-Patches-462759 ] socketmodule.c: SSL bugfixes

[noreply@sourceforge.net]

Patches item #462759, was opened at 2001-09-18 21:03
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=462759&group_id=5470

Category: Modules
Group: None
>Status: Closed
Resolution: Accepted
Priority: 7
Submitted By: Gerhard Häring (ghaering)
Assigned to: Jeremy Hylton (jhylton)
Summary: socketmodule.c: SSL bugfixes

Initial Comment:
This patch fixes the following bugs:

#461358: SSL constructor/destructor bugs
#461353: SSL write doesn't check return codes
#461350: SSL support crashes python
It also adds more reliable error checking to the SSL
methods. And it tries to clean up the code by removing
unused variables, for example.

I'm an OpenSSL newbie myself, so a code review
definitely won't hurt. I'll also try myself if I can
talk some OpenSSL experts into reviewing it.

As for testcases, Python currently doesn't offer
server-side SSL functionality, so any serious
client-server testing isn't possible at the moment. I'm
also unsure whether patch #452110, that adds this
should be added in the current form.

I'd rather see a seperate new sslmodule.c that
implements something largely interface compatible with
socketmodule.c, i. e. with .recv(), .makefile() and all
the rest. This would, however, require a serious
effort. I doubt that a new SSL implementation could be
implemented in a stable way for Python 2.2. The new
sslmodule.c could be a combination of the above
mentioned patch, the BSD-licensed Python-OpenSSL
modules and perhaps some of the current code.


----------------------------------------------------------------------

Comment By: Jeremy Hylton (jhylton)
Date: 2001-10-11 09:46

Message:
Logged In: YES 
user_id=31392

I'm sorry I forgot about this patch.  It covers a lot of the
same ground that I covered in yesterday's changes to
socketmodule.c.  I'll work on applying the rest of the
changes relative to the current version of socketmodule.c.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=462759&group_id=5470