[Patches] [ python-Patches-421709 ] Access { thread id : frame } dict

[noreply@sourceforge.net]

Patches item #421709, was opened at 2001-05-05 13:30
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=421709&group_id=5470

Category: Core (C code)
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 5
Submitted By: John D. Heintz (jheintz)
Assigned to: Barry Warsaw (bwarsaw)
Summary: Access { thread id : frame } dict

Initial Comment:
This patch adds a new function sys._getframes() that 
returns a dictionary mapping from thread id to 
current frame object.

This is very useful when diagnosing deadlock issues 
in Python code.

The new C code function is purely additive except for 
modifying the PyThreadState struct (adding a long 
thread_ident) and modifying PyThreadState_New() 
function to set this new long.



----------------------------------------------------------------------

>Comment By: Barry Warsaw (bwarsaw)
Date: 2001-10-18 15:47

Message:
Logged In: YES 
user_id=12800

In keeping with Martin's last comment, I'm closing this
patch.  If the issues brought up are addressed, we can
re-evaluate it for Python 2.3.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-08-16 12:02

Message:
Logged In: YES 
user_id=21627

I propose to close this patch if it is not updated by Oct 
1, 2001. If it is not updated by the time the last alpha 
is released, it probably has no chance to go into Python 
2.2.


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-06-05 01:00

Message:
Logged In: YES 
user_id=21627

There is a difference between these two functions. _getframe
is not an
official API; inspect.currentframe is the official API. It
seems that
your function is meant to be used via sys, so it would be
public
there.

In any case, I also think that  the sys._getframe doc string
should
not talk about intended uses - if anything, it should
mention what
function to call instead.


----------------------------------------------------------------------

Comment By: John D. Heintz (jheintz)
Date: 2001-06-04 10:52

Message:
Logged In: YES 
user_id=20438

Martin:  I agree with you on the documentation issue and 
will look into the tuple size issue you raised.

The docstring is modeled on the sys._getframe() function 
so I figured it would be sufficient to follow the leader.

(I think that both sys._getframe() and sys._getframes() 
should be part of the public api for the sys module by the 
way.)


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-06-04 10:28

Message:
Logged In: YES 
user_id=21627

I think the patch could use some more documentation, e.g. 
as a patch to Doc/lib/libsys.tex. E.g. what are the tuples 
that are put into the dictionaries?

Also, isn't there a problem with the tuple size? The patch 
allocates tuples of size 0, but then puts things into 
index 0. Is there any kind of test case for this code?

Finally, I don't think the docstring should say that the 
function is for internal and specialized purposes only 
(what specialized purposes, anyway), if you think its 
primary use is in diagnosing deadlocks. It should only 
document what the function does, not what you intend it to 
use for.

For these reasons, I also think its name should not start 
with an underscore.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=421709&group_id=5470