[Patches] [ python-Patches-473749 ] compile under OS/2 VA C++

[noreply@sourceforge.net]

Patches item #473749, was opened at 2001-10-22 12:00
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=473749&group_id=5470

Category: Build
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Michael Muller (mikemuller)
Assigned to: Nobody/Anonymous (nobody)
Summary: compile under OS/2 VA C++

Initial Comment:
This is the minimal set of changes I found necessary to
get the latest Python CVS image built under OS/2 Visual
Age C++.

I'm pretty sure that some of these changes will
conflict with changes submitted by Andrew MacIntyre for
OS/2 EMX.  If his changes are checked in before mine,
I'd be happy to resolve the conflicts and resubmit this
patch.


----------------------------------------------------------------------

>Comment By: Michael Muller (mikemuller)
Date: 2001-10-30 10:46

Message:
Logged In: YES 
user_id=353708

1) "#ifdef __BEOS__" vs. "#if defined(__BEOS_)"

  This is not necessary.  I was under the mistaken impression that #ifdef ... #elif caused problems
under VAC++.

3) positive case first

  I agree.

I have posted another patch which addresses these issues.

----------------------------------------------------------------------

Comment By: Andrew I MacIntyre (aimacintyre)
Date: 2001-10-30 04:50

Message:
Logged In: YES 
user_id=250749

1) in Modules/socketmodule.c, is changing "#ifdef __BEOS__" to "#if defined(__BEOS__)" absolutely necessary?
While I would also do this, others view such apparently cosmetic changes with suspicion.
2) the changes to the files in PC/os2vacpp look OK.
3) in Python/bltinmodule.c,  I would have suggested using

#if <OS/2 defs>
  <OS/2 specific code>
#else
  <generic code>
#endif

rather than

#if !<OS/2 defs>
  <generic code>
#else
  <OS/2 specific code>
#endif

Negated #ifdefs seem to be considerably in the minority in the Python source tree AFAICS.

4) change to Python/importdl.h is OK as its in an #ifdef OS2

The changes noted in 2) & 4) look good to go.  Feedback from anyone else about the stylistics noted in 1) & 3)?

----------------------------------------------------------------------

Comment By: Michael Muller (mikemuller)
Date: 2001-10-26 05:37

Message:
Logged In: YES 
user_id=353708

Resubmitted to resolve conflict with changes to bltinmodule.c

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=473749&group_id=5470