[Patches] [ python-Patches-401335 ] Adds login to auth-type servers (smtplib.py)

[noreply@sourceforge.net]

Patches item #401335, was opened at 2000-08-29 01:05
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=401335&group_id=5470

Category: Library (Lib)
Group: None
Status: Closed
Resolution: Rejected
Priority: 5
Submitted By: Ulf Engstrшm (alexisjuh)
Assigned to: Jeremy Hylton (jhylton)
Summary: Adds login to auth-type servers (smtplib.py)

Initial Comment:
 

----------------------------------------------------------------------

Comment By: Gerhard Hдring (ghaering)
Date: 2001-09-09 11:03

Message:
Logged In: YES 
user_id=163326

Stupid me. This patch is already rejected, so I'll submit a
new one, once I'm ready.

----------------------------------------------------------------------

Comment By: Gerhard Hдring (ghaering)
Date: 2001-09-09 10:59

Message:
Logged In: YES 
user_id=163326

I'd also recommend to reject this particular patch. No
offense, but it seems more like a quick hack for a
particular problem than something belonging into the Python
standard library to me.

I'm working on SMTP AUTH support for smtplib and have a
working prototype for the AUTH methods "PLAIN" and
"CRAM-MD5". This still needs a lot of cleaning up and some
serious testing. Would you prefer this as a new patch or
submitted here to keep things in one place?


----------------------------------------------------------------------

Comment By: Jeremy Hylton (jhylton)
Date: 2001-08-09 07:52

Message:
Logged In: YES 
user_id=31392

I've never looked at this patch <hangs head in shame>, so
I'll defer to Martin who has given it some serious attention.


----------------------------------------------------------------------

Comment By: Martin v. Lцwis (loewis)
Date: 2001-06-04 00:37

Message:
Logged In: YES 
user_id=21627

I've transformed this into a patch into a diff-style 
patch. I've left out the self.authenticated attribute, 
since it appears never to be set, and since its purpose is 
unclear.

Applying the patch seems harmless, since it just adds 
another method to the SMTP class. I still recommend 
rejecting it, since it has no apparent relationship to RFC 
2554. In that RFC, the AUTH line of the EHLO response will 
contain a list of SASL authentication mechanisms, as 
defined in RFC 2222, and listed in 
http://www.iana.org/assignments/sasl-mechanisms

So a valid AUTH request would be "AUTH CRAM-MD5", as the 
example in RFC 2554 shows. "AUTH login", as implemented in 
this patch, does not conform to the RFC. Therefore, I 
recommend to reject this patch.


----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-01-04 07:44

Message:
Jeremy, can you look at this again?

----------------------------------------------------------------------

Comment By: Moshe Zadka (moshez)
Date: 2000-08-29 02:22

Message:
Postponed -- we're in feature freeze.
Assigned to Jeremy in case he disagrees.
Note also that it's preferable to submit patches in diff format, not as human-readable summaries. Try "diff -c".

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=401335&group_id=5470