[Patches] [ python-Patches-465298 ] Fix for xmlrpclib's recursive dump

[noreply@sourceforge.net]

Patches item #465298, was opened at 2001-09-26 10:09
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=465298&group_id=5470

Category: Library (Lib)
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Mihai Ibanescu (misa)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fix for xmlrpclib's recursive dump

Initial Comment:
A perfectly valid case:

p = []
a = [p, p]

print xmlrpclib.dumps((a,))

xmlrpclib is fooled by having the same container object
twice, even if it's not a recursive data structure.

----------------------------------------------------------------------

>Comment By: Mihai Ibanescu (misa)
Date: 2001-09-27 11:21

Message:
Logged In: YES 
user_id=205865

Okay, the patch was broken. I was working on the wrong tree
and generated the patch against the wrong version. The
second patch fixes this but it still uses the sloppy
list-creation stuff.

Please have a look at the third patch. Now I am really using
a stack and performance-wise it should be much better. It
also makes the change more local.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-09-26 13:46

Message:
Logged In: YES 
user_id=21627

I have a number of comments on this patch:
- please reread your patch carefully. E.g. why did you 
change 'use the "dumps" method' into 'use "dumps" method'?
- It appears that all dump methods now require the 
additional memo argument. For this implementation 
strategy, it appears that argument should not be optional.
- Please analyse the performance properties of this 
implementation strategy. It appears that you create a new 
list for each container. Instead, it seems better to use a 
dictionary as a set, adding the ids every time you descend 
into the container, and removing it when you are done. 
That would be a much smaller change also.


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=465298&group_id=5470