[Patches] [ python-Patches-543865 ] bugfixes on complexobject.c

[noreply@sourceforge.net]

Patches item #543865, was opened at 2002-04-14 18:03
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=543865&group_id=5470

Category: Core (C code)
Group: None
>Status: Closed
Resolution: None
Priority: 5
Submitted By: Hernan Martinez Foffani (hfoffani)
Assigned to: Nobody/Anonymous (nobody)
Summary: bugfixes on complexobject.c

Initial Comment:
A patch that fixes bugs #543840 (complex() constructor
doesn't fail in certain cases) and #543387 (floor
division doen't raise exception as indicates PEP 238)
is included here.

For the first bug, I moved a block of C code that
checks the presence of '\0' outside the loop.

For the other one, I just cleared the nb_floor_divide
entry in the table. Also deleted the complex_int_div()
function.

I'm uploading also tests for this patch, but it goes on
a   different submit.



----------------------------------------------------------------------

Comment By: Hernan Martinez Foffani (hfoffani)
Date: 2002-04-15 05:43

Message:
Logged In: YES 
user_id=112690

Yes. I think this entry should be closed as its targets 
are/were taken care in bug entries #543387 / #543840.


----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-04-14 20:34

Message:
Logged In: YES 
user_id=33168

Should this patch be closed since #543867 was entered?

----------------------------------------------------------------------

Comment By: Hernan Martinez Foffani (hfoffani)
Date: 2002-04-14 20:03

Message:
Logged In: YES 
user_id=112690

Ok, done!

Bug report #543387 has patch and test suite.

Pure enhancements to complex numbers tests stay at patch
submission #543847 but now they don't include code related
to the the reported bugs.

Please, sorry for the mess.


----------------------------------------------------------------------

Comment By: Tim Peters (tim_one)
Date: 2002-04-14 18:16

Message:
Logged In: YES 
user_id=31435

Note that 543840 got fixed before you uploaded this patch, 
so please take that out of this patch (one bug == one patch 
is an excellent idea, and you can attach a patch to the bug 
report instead).  Please combine the remaining patch with 
the test-suite change too -- opening lots of distinct 
tracker items makes more work for everyone (including you!).

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=543865&group_id=5470