[Patches] [ python-Patches-592529 ] Split-out ntmodule.c

[noreply@sourceforge.net]

Patches item #592529, was opened at 2002-08-08 06:12
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=592529&group_id=5470

Category: Windows
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Martin v. Löwis (loewis)
>Assigned to: Guido van Rossum (gvanrossum)
Summary: Split-out ntmodule.c

Initial Comment:
This patch moves the MS_WINDOWS code from 
posixmodule.c into ntmodule.c. The OS/2 code is left in 
posixmodule.c.

I believe this patch significantly improves readability of 
both modules (posix and nt), even though it adds a 
slight code duplication. It also gives Windows 
developers the chance to adjust the implementation 
better to the Win32 API without fear of breaking the 
POSIX versions.

Attached are three files: the ntmodule.c source code, 
the posixmodule.c diff, and the pcbuild diff. Since the 
patches will outdate quickly, I'd appreciate if that patch 
could be accepted or rejected quickly.

Randomly assigning to Tim.

----------------------------------------------------------------------

>Comment By: Tim Peters (tim_one)
Date: 2002-08-08 12:32

Message:
Logged In: YES 
user_id=31435

I'm -0, so assigning to Guido for another opinion.  I expect 
this will actually make it harder to keep the os interface 
consistent and working across platforms; e.g., somebody 
adds an os function in one module but forgets to add it in the 
other (likely because they don't even know it exists); a 
docstring repair shows up in one but not both; a largefile fix in 
one doesn't get reflected in the other; etc.  Apart from the 
massive Windows popen pain, there are actually more 
embedded PYOS_OS2 #ifdefs in posixmodule.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=592529&group_id=5470