[Patches] [ python-Patches-554192 ] mimetypes: all extensions for a type

[noreply@sourceforge.net]

Patches item #554192, was opened at 2002-05-09 19:31
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=554192&group_id=5470

Category: Library (Lib)
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Walter Dörwald (doerwalter)
Assigned to: Martin v. Löwis (loewis)
Summary: mimetypes: all extensions for a type

Initial Comment:
This patch adds a function guess_all_extensions to 
mimetypes.py. This function returns all known 
extensions for a given type, not just the first one 
found in the types_map dictionary. guess_extension is 
still present and returns the first from the list.

----------------------------------------------------------------------

>Comment By: Walter Dörwald (doerwalter)
Date: 2002-08-19 14:57

Message:
Logged In: YES 
user_id=89016

diff3.txt adds a strict=True to add_type and to all methods
that call add_type (i.e. read() and readfp()). types_map and
common_types are combined into a dict tuple (in the class,
on the module level they are still two dicts, to be
backwards compatible.)

What about adding a guess_all_types(), that returns a list
of all registered mimetypes for an exception? This way we
would be able to handle duplicates.

----------------------------------------------------------------------

Comment By: Barry A. Warsaw (bwarsaw)
Date: 2002-08-15 20:18

Message:
Logged In: YES 
user_id=12800

If add_type() is going to be public, shouldn't it have a
"strict" flag to decide whether to add it to the standard
types dict or the common types dict?


----------------------------------------------------------------------

Comment By: Walter Dörwald (doerwalter)
Date: 2002-08-15 19:40

Message:
Logged In: YES 
user_id=89016

diff2.txt adds the global version of add_type and the
documentation in Doc/lib/libmimetypes.tex.

----------------------------------------------------------------------

Comment By: Walter Dörwald (doerwalter)
Date: 2002-07-31 13:24

Message:
Logged In: YES 
user_id=89016

OK, I'll change the patch and post the question to python-dev 
next week (I'm on vacation right now).

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-07-30 14:34

Message:
Logged In: YES 
user_id=21627

I'm in favour of exposing it on the module level. If you are
uncertain, you might want to ask on python-dev.

----------------------------------------------------------------------

Comment By: Walter Dörwald (doerwalter)
Date: 2002-07-30 13:00

Message:
Logged In: YES 
user_id=89016

It *is* used in two spots: The constructor and the readfp 
method. But exposing it at the module level could make 
sense, because it is the atomic method of adding mime type 
information. So should it change the patch to expose it at the 
module level and change the LaTeX documentation 
accordingly?

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-07-29 10:44

Message:
Logged In: YES 
user_id=21627

I can't see the point of making it private, since it is not
used inside the module. If you plan to use it, that usage
certainly is outside of the module, so the method would be
public.

If it is public, it needs to be exposed on the module level,
and it needs to be documented.

----------------------------------------------------------------------

Comment By: Walter Dörwald (doerwalter)
Date: 2002-07-29 10:23

Message:
Logged In: YES 
user_id=89016

The patch adds an inverted mapping (i.e. mapping from type
to a list of extensions). add_type simplifies adding a
type<->ext mapping to both dictionaries. If this method
should not be exposed we could make the name private.
(_add_type)

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-07-28 12:30

Message:
Logged In: YES 
user_id=21627

What is the role of add_type in this patch?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=554192&group_id=5470