[Patches] [ python-Patches-597220 ] frameobject.c cache friendliness patch

noreply@sourceforge.net noreply@sourceforge.net
Mon, 19 Aug 2002 09:49:03 -0700


Patches item #597220, was opened at 2002-08-19 12:40
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=597220&group_id=5470

Category: Core (C code)
Group: Python 2.3
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: Michael Hudson (mwh)
>Assigned to: Michael Hudson (mwh)
Summary: frameobject.c cache friendliness patch

Initial Comment:
I was playing around with cachegrind, a cache profiler,
and noticed that some error checking code in
PyFrame_New generated quite a lot of cache misses.  

As the test is never going to pass without very dodgy C
code, I've moved it inside Py_DEBUG.

----------------------------------------------------------------------

>Comment By: Guido van Rossum (gvanrossum)
Date: 2002-08-19 12:49

Message:
Logged In: YES 
user_id=6380

Hm. The type tests on code and back are clearly bogus, since
the variable types are already proof enough. So those can go
altogether.

For the rest I agree.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=597220&group_id=5470