[Patches] [ python-Patches-654960 ] remove unnecessary static variable

[noreply@sourceforge.net]

Patches item #654960, was opened at 2002-12-16 20:46
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=654960&group_id=5470

Category: Core (C code)
Group: Python 2.3
>Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
Assigned to: Neal Norwitz (nnorwitz)
Summary: remove unnecessary static variable

Initial Comment:
There is a static object in compile.c,
symtable_load_symbols():  implicit = PyInt_FromLong(1);

I think this should be the same as Py_True now.  This
patch removes the static and uses Py_True.

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2002-12-17 20:19

Message:
Logged In: YES 
user_id=33168

I agree about None vs any other value.  Updated doc. 
Checked in as Python/compile.c 2.268

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-12-17 18:51

Message:
Logged In: YES 
user_id=21627

AFAICT, it doesn't really matter whether this is 1 or any
other value, as long as it is not None.

Please update the c_globals documentation that the values
can also be True; apart from this, the patch is fine.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=654960&group_id=5470