[Patches] [ python-Patches-450265 ] OS/2 + EMX port - PC directory files

[noreply@sourceforge.net]

Patches item #450265, was opened at 2001-08-12 04:14
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=450265&group_id=5470

Category: Build
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Andrew I MacIntyre (aimacintyre)
Assigned to: Nobody/Anonymous (nobody)
Summary: OS/2 + EMX port - PC directory files

Initial Comment:
The attached patch contains all the changes to the PC directory in the source tree between Python 2.1.1 and the 
010812 release of the OS/2+EMX port.  This comprises changes to PC/getpathp.c and a new subdirectory, 
PC/os2emx, which contains the Makefile, config.[ch], dlfcn.[ch], dllentry.c, python DLL .DEF file and a copy of the 
port's README.os2emx.

At the moment, building dynamic modules is still handled by the supplied Makefile, rather than a DistUtils setup.py 
script.

----------------------------------------------------------------------

>Comment By: Andrew I MacIntyre (aimacintyre)
Date: 2002-01-02 15:19

Message:
Logged In: YES 
user_id=250749

I am preparing updated patches against CVS for this and the 
other EMX related patches, and will upload in the next few 
days.

Specifically for this patch, the updated version will just 
add a PC/os2emx subdirectory, and touch no other files in 
the PC directory (as the patch currently attached does).

Would it be better to reject the 4 currently outstanding 
patches and submit new ones for this, or just update the 
current ones?

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-12-28 14:47

Message:
Logged In: YES 
user_id=21627

Andrew, are you still interested in updating this patch?
Otherwise, I recommend to reject it.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-10-01 15:41

Message:
Logged In: YES 
user_id=21627

What kind of action would you like to see on this code? In 
the areas where it changes existing code, there are some 
questionable chunks, which I would not like to see in 
Python:
- removal of comments
- change of control logic without giving a rationale. E.g. 
there was an explicit comment
/* If we have no values, we dont need a ';' */
Your patch changes this to give a ; in all cases. Why?
Why is the addition of a terminating null in wprogpath 
removed?


----------------------------------------------------------------------

Comment By: Guido van Rossum (gvanrossum)
Date: 2001-08-12 07:45

Message:
Logged In: YES 
user_id=6380

Andrew, your patch attachment didn't work. Please try again,
making sure you check the "file upload checkbox".

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=305470&aid=450265&group_id=5470