[Patches] [ python-Patches-553702 ] Cygwin make install patch

[noreply@sourceforge.net]

Patches item #553702, was opened at 2002-05-08 14:44
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=553702&group_id=5470

Category: Build
Group: None
Status: Open
>Resolution: Accepted
Priority: 5
Submitted By: Jason Tishler (jlt63)
>Assigned to: Jason Tishler (jlt63)
Summary: Cygwin make install patch

Initial Comment:
This patch fixes make install for Cygwin. Specifically, it reverts
to the previous behavior:

o install libpython$(VERSION)$(SO) in $(BINDIR)
o install $(LDLIBRARY) in $(LIBPL)

It also begins to remove Cygwin's dependency on
$(DLLLIBRARY) which I hope to take advantage of
when I attempt to make Cygwin as similar as possible
to the other Unix platforms (in other patches).

I tested this patch under Red Hat Linux 7.1 without
any ill effects.

BTW, I'm not the happiest using the following
test for Cygwin:

test "$(SO)" = .dll

I'm willing to update the patch to use:

case "$(MACHDEP)" in cygwin*

instead, but IMO that will look uglier.



----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2002-07-05 07:31

Message:
Logged In: YES 
user_id=21627

I think I misinterpreted your patch. It is fine; please
apply it.

----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2002-06-27 18:25

Message:
Logged In: YES 
user_id=86216

Sorry for sluggish response time...

Under Cygwin, my patch does the following:

make altbininstall:
/usr/bin/install -c -m 555 libpython2.3.dll /usr/bin

make libainstall:
/usr/bin/install -c -m 644 libpython2.3.dll.a /usr/lib/python2.3/config

So, I am installing the shared library during altbininstall
and the import library during libainstall. Isn't this what
you were asking for in your previous message? Or, do
you want me to install both files during altbininstall?

I'm confused.  Please clarify.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-06-06 11:49

Message:
Logged In: YES 
user_id=21627

On Unix, if a shared libpython is created, it is installed
as part of altbininstall, not as part of libainstall. I feel
that pythonxy.dll is not really a library, but a binary -
quite unlike libpythonxy.a (which is more close to the
import library). So I feel that this patch would better be
incorporated into altbininstall.

----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2002-06-04 17:17

Message:
Logged In: YES 
user_id=86216

Please review when you get a chance, thanks.

----------------------------------------------------------------------

Comment By: Jason Tishler (jlt63)
Date: 2002-05-22 18:30

Message:
Logged In: YES 
user_id=86216

Can I commit this one? Note that make install is
busted under Cygwin without this patch.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=553702&group_id=5470