[Patches] [ python-Patches-578494 ] PEP 282 Implementation
noreply@sourceforge.net
noreply@sourceforge.net
Tue, 09 Jul 2002 19:22:51 -0700
Patches item #578494, was opened at 2002-07-08 10:50
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=578494&group_id=5470
Category: Library (Lib)
Group: Python 2.3
>Status: Pending
Resolution: None
Priority: 5
Submitted By: Vinay Sajip (vsajip)
Assigned to: Mark Hammond (mhammond)
Summary: PEP 282 Implementation
Initial Comment:
The attached file implements PEP282. The file logging-
0.4.6.tar.gz is the entire distribution including
setup/install, test/example scripts, and TeX
documentation. The file logging.py (within the .tar.gz) is
all that is needed to implement the PEP.
----------------------------------------------------------------------
>Comment By: Mark Hammond (mhammond)
Date: 2002-07-10 12:22
Message:
Logged In: YES
user_id=14198
The code seems high quality and well documented. I have no
concerns with logging.py as such.
I have two main issues:
* Design decisions: looking over python-dev, I can not see
a consensus on the design decisions. I believe that *some*
type of official acceptance of the design should be decreed
by someone.
* Source structure: while this seems quite suitable for an
extension module, the format of the patch is probably not
quite correct for a core module. For example, the test code
should probably be integrated with the standard Python test
suite (even if in a sub-directory), the Tex docs integrated
with Python's docs etc
So while I think the patch is high quality I believe these
issues need to be addressed before I can do much more.
Setting to "pending" - but good stuff tho! Please drive
this through!
----------------------------------------------------------------------
Comment By: Vinay Sajip (vsajip)
Date: 2002-07-08 10:56
Message:
Logged In: YES
user_id=308438
Added just the logging.py file to make it easier to review.
----------------------------------------------------------------------
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=578494&group_id=5470