[Patches] [ python-Patches-401229 ] Optional memory profiler

[noreply@sourceforge.net]

Patches item #401229, was opened at 2000-08-19 08:49
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=401229&group_id=5470

Category: Core (C code)
Group: None
>Status: Closed
>Resolution: Rejected
Priority: 3
Submitted By: Vladimir Marangozov (marangoz)
Assigned to: Jeremy Hylton (jhylton)
Summary: Optional memory profiler

Initial Comment:
 

----------------------------------------------------------------------

>Comment By: Martin v. Löwis (loewis)
Date: 2002-07-15 12:25

Message:
Logged In: YES 
user_id=21627

I'm closing this patch now. I believe the statistics
functions of Tim's recent pymalloc changes overlap in
functionalilty with this patch, and apparently, nobdody has
a real need for the feature.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-03-09 11:42

Message:
Logged In: YES 
user_id=21627

I still recommend to reject this patch.

----------------------------------------------------------------------

Comment By: Jeremy Hylton (jhylton)
Date: 2001-08-09 16:51

Message:
Logged In: YES 
user_id=31392

I had the impression that the feature was useful, but
haven't had any time to spend on it.  I'm not sure if
spending time on it before 2.2 is a good use of time or not.
 I'd rather keep this patch around as a reminder than close
it, but I'll mark it out of date and give it a low priority.


----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2001-06-04 09:02

Message:
Logged In: YES 
user_id=21627

The patch, in its current form, fails to apply (4 hunks 
fail). Also, the URL of the discussion of the patch 
changed to

http://mail.python.org/pipermail/python-dev/2000-August/008527.html

I recommend to reject this patch, since I cannot see what 
use the information it produces has to a Python developer.
If there is a desire to have the feature in Python, I'd 
volunteer to provide an updated patch.


----------------------------------------------------------------------

Comment By: Vladimir Marangozov (marangoz)
Date: 2000-08-19 09:18

Message:
An optional memory profiler, which goes in tandem with the optional
object memory allocator (SourceForge patch #101104). The profiler was
introduced briefly on python-dev:
http://www.python.org/pipermail/python-dev/2000-August/015239.html

Applying both patches gives for me (screen dump):

~> patch -p1 < ../obmalloc-patch
patching file `Include/objimpl.h'
patching file `Objects/object.c'
patching file `Objects/obmalloc.c'
patching file `acconfig.h'
patching file `configure.in'
~> patch -p1 < ../memprof-patch
patching file `Include/pydebug.h'
patching file `Modules/Setup.config.in'
patching file `Modules/main.c'
patching file `Modules/memprof.c'
patching file `Python/pythonrun.c'
patching file `acconfig.h'
patching file `configure.in'

- Don't forget that you need to autoheader; autoconf;

This patch:

1) introduces a new --with-memprof configure option. Off by default.
2) introduced a Py_ProfileFlag and a "-p" Python option which starts
    the profiler in Py_Initialize() before any initializations, and stops it
    in Py_Finalize() after all finalizations.
3) contains a new Modules/memprof.c module. The inclusion of this file
   in the core is similar to the thread and GC modules (Setup.config.in)

The patch *can* be applied without the object allocator and it *does*
compile on request. However, it issues a warning that it won't profile
anything, because it can't be called (the profiler can't install its hooks).
Besides, it will refuse to start(). The point is that both the profiler and
the allocator are really optional.

Needs docs & tests :( The interface can be improved (just like everything
else) but the core functionality is there. It *is* useful for getting snapshots
of the minimum allocated (object) memory, at least. Some worthy points to
condifer, IMO, are listed in the TODO of memprof.c.

I am submitting this for testing, reviewing, comments and more ideas.
Overall, I think it is a BIG plus regarding Python's typical introspection.

Comments welcome. As usual, flames to /dev/null <wink>.

Status set straight to Postponed. Assigned to marangoz who's in charge of
opening it in due time, together with #101104.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=401229&group_id=5470