[Patches] [ python-Patches-577031 ] Remove PyArg_Parse() and METH_OLDARGS

[noreply@sourceforge.net]

Patches item #577031, was opened at 2002-07-03 11:57
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=577031&group_id=5470

Category: Core (C code)
Group: Python 2.3
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Neal Norwitz (nnorwitz)
>Assigned to: Neal Norwitz (nnorwitz)
Summary: Remove PyArg_Parse() and METH_OLDARGS

Initial Comment:
This patch removes more PyArg_Parse() and METH_OLDARGS
which are deprecated.
I've tested in select and string, but want to make sure
there's nothing else I'm missing.

I also have a huge change to glmodule, but I can't test
that.  The diff is attached.
Let me know if I should check in glmodule or leave it
alone.

----------------------------------------------------------------------

>Comment By: Neal Norwitz (nnorwitz)
Date: 2002-07-28 11:26

Message:
Logged In: YES 
user_id=33168

Closing this patch.  I'll make a new patch for changing
fmmodule as suggested.
Checked in as:  glmodule 2.10, stringobject.c 2.172,
selectmodule.c 2.68.

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-07-28 07:46

Message:
Logged In: YES 
user_id=21627

The other patches look all fine, please apply them. For
fmmodule, I'd recommend to convert those functions to
VARARGS/ParseTuple.

----------------------------------------------------------------------

Comment By: Neal Norwitz (nnorwitz)
Date: 2002-07-26 21:04

Message:
Logged In: YES 
user_id=33168

All the "s" / PyString_Check() changes are in fmmodule.  I
suggest to not patch fmmodule now.  Are all the other
changes ok?  Should I bother fixing glmodule at all?

----------------------------------------------------------------------

Comment By: Martin v. Löwis (loewis)
Date: 2002-07-05 01:45

Message:
Logged In: YES 
user_id=21627

The changes look good, except for the ones that change
parsing of "s" to PyString_Check: that means to lose support
for Unicode.

For some of these methods, that may be acceptable, but that
would need documentation.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=305470&aid=577031&group_id=5470